Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: --env not work during sealos run #4140

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: --env not work during sealos run #4140

merged 1 commit into from
Oct 23, 2023

Conversation

fengxsong
Copy link
Collaborator

@fengxsong fengxsong commented Oct 23, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at ea679c7

Summary

🔧🌐🧹

Improve environment variable handling for mount images in pkg/guest. Rename envs to imageEnvs and use append instead of os.Environ to merge variables.

guest mounts images
env vars renamed, merged
autumn leaves falling

Walkthrough

  • Rename envWrapper to envGetter to clarify its role (link)
  • Merge environment variables from mount image and node for each command (link, link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Oct 23, 2023 •
edited
Loading

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 956
✅ Successful 375
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 580
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 23, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@fengxsong @cuisongliu
fix: --env not work during sealos run
dd649df 
Signed-off-by: fengxsong <fengxsong@outlook.com>
@cuisongliu cuisongliu force-pushed the fix_env_not_work_during_run branch from ea679c7 to dd649df Compare October 23, 2023 03:48
@cuisongliu cuisongliu added this to the v4.4 milestone Oct 23, 2023
@cuisongliu cuisongliu merged commit 93961f7 into labring:main Oct 23, 2023
82 checks passed
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.4

@sealos-ci-robot
Copy link
Member

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/6608559948

sealos-ci-robot pushed a commit that referenced this pull request Oct 23, 2023
@fengxsong
fix: --env not work during sealos run (#4140)
f6bd846 
Signed-off-by: fengxsong <fengxsong@outlook.com>
cuisongliu pushed a commit that referenced this pull request Oct 23, 2023
@sealos-ci-robot @fengxsong
fix: --env not work during sealos run (#4140) (#4145)
e1a099e 
Signed-off-by: fengxsong <fengxsong@outlook.com>
Co-authored-by: fengxsong <fengxsong@outlook.com>
@fengxsong fengxsong deleted the fix_env_not_work_during_run branch October 24, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuisongliu cuisongliu cuisongliu approved these changes

Assignees
No one assigned
Labels
area/guest area/lifecycle-management size/XS
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fengxsong @sealos-ci-robot @cuisongliu