Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change _ to - #4183

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix: change _ to - #4183

merged 1 commit into from
Oct 27, 2023

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Oct 27, 2023

🤖 Generated by Copilot at 59b1969

Summary

♻️🔧📝

Updated install.sh script to use hyphens for options. This improves readability and aligns with common conventions.

The script for installing our app
Had options with underscores to zap
So we changed them to hyphens
And fixed up the typhens
Now install.sh is a snap

Walkthrough

  • Change option names and parsing logic to use hyphens instead of underscores (link, link, link, link) in scripts/cloud/install.sh

Signed-off-by: yy <lingdie.yy@outlook.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 956
✅ Successful 375
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 580
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 27, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@zzjin zzjin added this to the v5.0 milestone Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@zzjin zzjin merged commit bd118ed into labring:main Oct 27, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants