Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cronjob app to cloud. #4201

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat: add cronjob app to cloud. #4201

merged 1 commit into from
Oct 30, 2023

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Oct 30, 2023

🤖 Generated by Copilot at af6c13b

Summary

🌐🔒🕒

This pull request updates the deployment and configuration of the sealos cloud platform and the cronjob and license frontend applications. It improves the security, robustness, and clarity of the code and uses the GitHub container registry for the cronjob frontend image. It also introduces a new environment variable for the cloudPort and a variable for the wildcard certificate secret name.

To deploy sealos-cronjob with ease
We added some env vars and keys
We saved the image as tar
And quoted args with care
And tweaked the ingress and CORS policies

Walkthrough

  • Pull and save the image of the cronjob frontend from the GitHub container registry (link, link)
  • Run the cronjob frontend as a sealos application and pass the cloudPort as an environment variable (link, link)
  • Enable CORS and set the backend protocol to HTTP for the cronjob frontend ingress (link)
  • Include the cloudPort in the content security policy and the cors-allow-origin headers for the cronjob frontend ingress (link)
  • Add double quotes around the cloudPort variable to prevent word splitting and globbing in the deploy/cloud/scripts/init.sh file (link, link, link, link, link, link)
  • Add double quotes around the resource argument to prevent word splitting and globbing in the deploy/cloud/scripts/init.sh file (link)
  • Rename the service name and the image tag from sealos-db-provider to sealos-cronjob in the frontend/providers/cronjob/Makefile file (link, link)
  • Replace the hardcoded secret name for the wildcard certificate with a variable in the frontend/providers/license/deploy/manifests/ingress.yaml.tmpl file (link)
  • Add a license header to the frontend/providers/cronjob/deploy/manifests/ingress.yaml.tmpl file (link)

Signed-off-by: yy <lingdie.yy@outlook.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 956
✅ Successful 367
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 588
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 30, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@lingdie lingdie merged commit 97bd672 into labring:main Oct 30, 2023
53 checks passed
lingdie added a commit to lingdie/sealos that referenced this pull request Nov 3, 2023
* add license app to cloud. (labring#4196)

Signed-off-by: yy <lingdie.yy@outlook.com>

* feature(main): skip sealos.run rule (labring#4198)

* Update README (labring#4197)

Signed-off-by: Carson Yang <yangchuansheng33@gmail.com>

* add cronjob app to cloud. (labring#4201)

Signed-off-by: yy <lingdie.yy@outlook.com>

* fix run init job. (labring#4202)

Signed-off-by: yy <lingdie.yy@outlook.com>

* feat service license (labring#4195)

* feat: license service

Signed-off-by: jingyang <3161362058@qq.com>

* done

* tempalte

Signed-off-by: jingyang <3161362058@qq.com>

* done

Signed-off-by: jingyang <3161362058@qq.com>

* done

Signed-off-by: jingyang <3161362058@qq.com>

* docker build

Signed-off-by: jingyang <3161362058@qq.com>

* done

Signed-off-by: jingyang <3161362058@qq.com>

* license yaml

Signed-off-by: jingyang <3161362058@qq.com>

* image

* fix type bg

* env

* add oss

Signed-off-by: jingyang <3161362058@qq.com>

* done

Signed-off-by: jingyang <3161362058@qq.com>

cluster done

Signed-off-by: jingyang <3161362058@qq.com>

done

Signed-off-by: jingyang <3161362058@qq.com>

cluster done

Signed-off-by: jingyang <3161362058@qq.com>

done cluster

Signed-off-by: jingyang <3161362058@qq.com>

done

Signed-off-by: jingyang <3161362058@qq.com>

* fix build

Signed-off-by: jingyang <3161362058@qq.com>

* fix oss && only zh

Signed-off-by: jingyang <3161362058@qq.com>

* feat checkout wechat

Signed-off-by: jingyang <3161362058@qq.com>

* fix ci

Signed-off-by: jingyang <3161362058@qq.com>

---------

Signed-off-by: jingyang <3161362058@qq.com>

* Docs: update "What is Sealos?" (labring#4200)

Signed-off-by: Carson Yang <yangchuansheng33@gmail.com>

* refactor(main): unmount override container (labring#4161)

Signed-off-by: cuisongliu <cuisongliu@qq.com>

* feat: Create a demo plugin Monitor (labring#4184)

* feat: lens demo of web version

* chore: add & remove some packages

* fix: connect to desktop bug and change icon

* init: plugin Monitor init

* style: restore frontend/pnpm-workspace.yaml & pnpm-lock.yaml and create new ones in plugins/monitor

* restore: frontend/Makefile

* restore: frontend/pnpm-workspace.yaml

* restore

* feat:frontend license app (labring#4203)

* feat:frontend license app

Signed-off-by: jingyang <3161362058@qq.com>

* fix

Signed-off-by: jingyang <3161362058@qq.com>

* fix

* fix detail

Signed-off-by: jingyang <3161362058@qq.com>

---------

Signed-off-by: jingyang <3161362058@qq.com>

* Docs: update introduction (labring#4207)

Signed-off-by: Carson Yang <yangchuansheng33@gmail.com>

* fix license db uri (labring#4211)

Signed-off-by: yy <lingdie.yy@outlook.com>

* update price (labring#4212)

* docs: Automated Changelog Update for v4.3.7 (labring#4210)

* 🤖 add release changelog using robot.

Signed-off-by: sealos-release-robot <sealos-release-robot@sealos.io>

* Update CHANGELOG.md

---------

Signed-off-by: sealos-release-robot <sealos-release-robot@sealos.io>
Co-authored-by: cuisongliu <cuisongliu@qq.com>

* 🤖 add release changelog using rebot. (labring#4213)

* add alt names. (labring#4214)

Signed-off-by: yy <lingdie.yy@outlook.com>

* Update the workflow to automatically update the website image after the image is built (labring#4209)

Signed-off-by: Carson Yang <yangchuansheng33@gmail.com>

* fix(costcenter): fix unit & invoice amount (labring#4194)

* feat:docs add private cloud page (labring#4215)

* fix scripts (labring#4217)

* Fix database provider i18n. (labring#4216)

Signed-off-by: zzjin <tczzjin@gmail.com>

* fix user avator && url (labring#4218)

* fix user avator && url

Signed-off-by: jingyang <3161362058@qq.com>

* modify purchase page

Signed-off-by: jingyang <3161362058@qq.com>

* fix height

Signed-off-by: jingyang <3161362058@qq.com>

* fix docs

Signed-off-by: jingyang <3161362058@qq.com>

* fix params

* copy code

* license time

---------

Signed-off-by: jingyang <3161362058@qq.com>

* fix oss file name && docs footer (labring#4220)

* feat(frontend/desktop):support modify team limit (labring#4221)

* add acme resolver monitoring (labring#4223)

* feat:docs language-differentiated domain names (labring#4226)

* feat:standard cluster purchase process (labring#4225)

* feat:standard cluster purchase process

Signed-off-by: jingyang <3161362058@qq.com>

* fix cronjob

Signed-off-by: jingyang <3161362058@qq.com>

---------

Signed-off-by: jingyang <3161362058@qq.com>

* add cloud release ci.

Signed-off-by: yy <lingdie.yy@outlook.com>

---------

Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: Carson Yang <yangchuansheng33@gmail.com>
Signed-off-by: jingyang <3161362058@qq.com>
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Signed-off-by: sealos-release-robot <sealos-release-robot@sealos.io>
Signed-off-by: zzjin <tczzjin@gmail.com>
Co-authored-by: cuisongliu <cuisongliu@qq.com>
Co-authored-by: Carson Yang <yangchuansheng33@gmail.com>
Co-authored-by: zhujingyang <72259332+zjy365@users.noreply.github.com>
Co-authored-by: Wishrem <97738578+Wishrem@users.noreply.github.com>
Co-authored-by: Jiahui <4543bxy@gmail.com>
Co-authored-by: sealos-release-robot <sealos-release-robot@sealos.io>
Co-authored-by: xudaotutou <13435638964@163.com>
Co-authored-by: zzjin <zzjin@users.noreply.github.com>
@lingdie lingdie deleted the add-cornjob branch May 27, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants