-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cluster id for license controller. #4237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yy <lingdie.yy@outlook.com>
🤖 Generated by lychee actionSummary
Full action output |
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4237 +/- ##
=======================================
Coverage 65.45% 65.45%
=======================================
Files 8 8
Lines 660 660
=======================================
Hits 432 432
Misses 180 180
Partials 48 48 ☔ View full report in Codecov by Sentry. |
Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
fanux
approved these changes
Nov 9, 2023
Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: yy <lingdie.yy@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 91cb4d8
Summary
🆕🔑🔄
This pull request adds support for cluster-specific licenses in the license controller. It introduces a new component
LicenseActivator
to activate licenses of different types, and a new fieldClusterId
to theLicenseReconciler
,LicenseValidator
, andClaims
structs. It also modifies the deployment and secret manifests to inject the cluster id as an environment variable.Walkthrough
ClusterId
to theLicenseReconciler
struct and pass it to theLicenseValidator
andLicenseActivator
components (link, link, link)CLUSTER_ID
(link, link)LicenseActivator
that handles the logic of activating the license according to its type (link, link)accountutil
from the license controller file (link)ClusterId
to theLicenseValidator
struct and theIsLicenseValid
method and function (link, link)ClusterId
to theClaims
struct to represent the cluster id in the license token (link)ErrClusterIdNotMatch
to the errors package to indicate the cluster id mismatch (link)