Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add minio controller #4240

Closed
wants to merge 10 commits into from
Closed

feat: add minio controller #4240

wants to merge 10 commits into from

Conversation

nowinkeyy
Copy link
Contributor

Null

@pull-request-size Pull Request Size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Nov 3, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Nov 3, 2023 •
edited
Loading

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 974
✅ Successful 381
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 592
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@bxy4543 bxy4543 added this to the v5.0 milestone Nov 8, 2023
fanux
fanux reviewed Nov 9, 2023
View reviewed changes
controllers/minio/config/samples/minio_v1_bucket.yaml
@@ -0,0 +1,12 @@
apiVersion: minio.sealos.io/v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minio.sealos.io -> object.sealos.io

fanux
fanux reviewed Nov 9, 2023
View reviewed changes
controllers/minio/config/samples/minio_v1_miniouser.yaml
@@ -0,0 +1,12 @@
apiVersion: minio.sealos.io/v1
kind: MinioUser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ObjectStorageUser

fanux
fanux reviewed Nov 9, 2023
View reviewed changes
controllers/minio/controllers/bucket_controller.go
}

func buildBucketName(name, namespace string) string {
return strings.Split(namespace, "-")[1] + "-" + name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will panic if namespace not have "-"

fanux
fanux reviewed Nov 9, 2023
View reviewed changes
controllers/minio/controllers/miniouser_controller.go
userNamespace := req.Namespace

// check minio username if correct or not
if username != strings.Split(userNamespace, "-")[1] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panic

@bxy4543 bxy4543 closed this Nov 23, 2023
@nowinkeyy nowinkeyy deleted the minio-v2 branch December 13, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanux fanux fanux left review comments

Assignees
No one assigned
Labels
area/api area/cloud area/test size/XXL
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nowinkeyy @sealos-ci-robot @fanux @bxy4543