Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix svg compatibility problem #4250

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix svg compatibility problem #4250

merged 1 commit into from
Nov 3, 2023

Conversation

zjy365
Copy link
Contributor

@zjy365 zjy365 commented Nov 3, 2023

🤖 Generated by Copilot at de94616

Summary

🎨🛠️🚀

This pull request updates the website's appearance and performance by changing some of the header images and styles. It replaces some SVG and CSS backgrounds with PNG images, and adjusts the layout and responsiveness of the Banner component.

We're changing the header image, no more SVG
We're using PNG, for better speed and quality
We're tweaking the style sheet, to make it look neat
We're rocking the self-hosting page, with a new design and theme

Walkthrough

  • Replace SVG images with PNG images for header backgrounds on all pages (link, link, link, link)
  • Remove the import of HeaderSvg component from Header/index.tsx (link)
  • Use img elements with require function to load PNG images from static folder in HomeHeader and Header components (link, link)
  • Use a different PNG image for the header background on the self-hosting page in self-hosting/index.tsx (link)
  • Adjust the style and layout of the banner box on the home page (link, link)
    • Remove the line-height property from the .sealos-banner-box class in Banner/index.scss (link)
    • Add a media query to reduce the font size and weight of the .sealos-banner-box class on smaller screens in Banner/index.scss (link)
  • Set the width and position of the header image on the self-hosting page (link)
    • Add a style rule for the .header-img class in self-hosting/index.scss (link)

Signed-off-by: jingyang <3161362058@qq.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 981
✅ Successful 379
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 601
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 3, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

@sealos-ci-robot
Copy link
Member

📘 Preview documentation website

👀 Visit Preview

@yangchuansheng yangchuansheng added this to the v5.0 milestone Nov 3, 2023
@yangchuansheng yangchuansheng merged commit e0838da into labring:main Nov 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants