Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cloud version #4255

Merged
merged 1 commit into from
Nov 4, 2023
Merged

fix cloud version #4255

merged 1 commit into from
Nov 4, 2023

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Nov 4, 2023

πŸ€– Generated by Copilot at 14f0081

Summary

πŸ”§πŸŒ₯οΈπŸ“

Rename CLOUD_VERSION to cloud_version in scripts/cloud/install.sh. This improves the code style and avoids variable name clashes.

The script had a variable CLOUD_VERSION
But it caused some confusion and tension
So they changed it to cloud_version
And updated the references with precision
Now the code is more clear and consistent

Walkthrough

  • Rename CLOUD_VERSION variable to cloud_version to follow shell convention and avoid confusion (link, link, link, link, link, link)

Signed-off-by: yy <lingdie.yy@outlook.com>
@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 981
βœ… Successful 312
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 668
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 4, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

@cuisongliu cuisongliu merged commit 4565660 into labring:main Nov 4, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants