-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:license deployment command #4316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jingyang <3161362058@qq.com>
π€ Generated by lychee actionSummary
Full action output |
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #4316 +/- ##
=======================================
Coverage 65.45% 65.45%
=======================================
Files 8 8
Lines 660 660
=======================================
Hits 432 432
Misses 180 180
Partials 48 48 β View full report in Codecov by Sentry. |
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
Signed-off-by: jingyang <3161362058@qq.com>
zzjin
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π€[deprecated] Generated by Copilot at 978cad4
Summary
ππ οΈπ
This pull request adds a new feature to the frontend and the backend of the sealos app that allows users to perform a formal deploy of the app to the cluster after a successful dryrun. It also improves the navigation and communication between the app launchpad iframe and the app detail pages for different app types. Additionally, it refactors some components and improves the code formatting and readability. Some of the files and components affected by this pull request are
_app.tsx
,BreadCrumbHeader.tsx
,CodeBlock.tsx
,ReadMe.tsx
,Tutorial.tsx
,TagTextarea.tsx
, andCommandForm.tsx
.Walkthrough
TagTextarea
, which allows the user to input multiple values as tags, and use the enter key to save them (link, link, link)CommandForm
, which allows the user to generate the bash script for installing the cluster with different parameters (link, link, link, link)CodeBlock
component fromcode
andcopyValue
tocopyCode
anddisplayCode
, and add a hover effect for the copy button (link, link, link, link, link)ReadMe.tsx
andTutorial.tsx
, as the readme is now embedded in the app launchpad iframe (link, link, link)useEffect
fromfrontend/providers/applaunchpad/src/pages/_app.tsx
(link)