Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:license deployment command #4316

Merged
merged 2 commits into from
Nov 18, 2023
Merged

feat:license deployment command #4316

merged 2 commits into from
Nov 18, 2023

Conversation

zjy365
Copy link
Contributor

@zjy365 zjy365 commented Nov 18, 2023

πŸ€–[deprecated] Generated by Copilot at 978cad4

Summary

πŸš€πŸ› οΈπŸŒ

This pull request adds a new feature to the frontend and the backend of the sealos app that allows users to perform a formal deploy of the app to the cluster after a successful dryrun. It also improves the navigation and communication between the app launchpad iframe and the app detail pages for different app types. Additionally, it refactors some components and improves the code formatting and readability. Some of the files and components affected by this pull request are _app.tsx, BreadCrumbHeader.tsx, CodeBlock.tsx, ReadMe.tsx, Tutorial.tsx, TagTextarea.tsx, and CommandForm.tsx.

We're the masters of the code, we make the apps deploy
We use the hooks and tags, we optimize the flow
We clean the blanks and whites, we refactor and improve
We're the masters of the code, we make the apps deploy

Walkthrough

  • Add a new feature for formal deploy, which allows the user to deploy the app to the cluster after a dryrun (link, link, link, link, link, link, link, link, link, link, link)
  • Add a new feature for internal app call, which allows the user to jump to the app, cronjob, or db detail page from the app launchpad iframe (link, link, link, link, link, link)
  • Add a new component TagTextarea, which allows the user to input multiple values as tags, and use the enter key to save them (link, link, link)
  • Add a new component CommandForm, which allows the user to generate the bash script for installing the cluster with different parameters (link, link, link, link)
  • Change the props of the CodeBlock component from code and copyValue to copyCode and displayCode, and add a hover effect for the copy button (link, link, link, link, link)
  • Remove the unused state and effect for fetching and setting the template readme in ReadMe.tsx and Tutorial.tsx, as the readme is now embedded in the app launchpad iframe (link, link, link)
  • Remove the unused import of useEffect from frontend/providers/applaunchpad/src/pages/_app.tsx (link)
  • Remove the extra blank lines for better formatting in various files (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)

Signed-off-by: jingyang <3161362058@qq.com>
@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Nov 18, 2023

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 1045
βœ… Successful 365
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 679
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 18, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (a3412cd) 65.45% compared to head (4d9ae36) 65.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4316   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

Signed-off-by: jingyang <3161362058@qq.com>
@zzjin zzjin added this to the v5.0 milestone Nov 18, 2023
@zzjin zzjin merged commit 7fd40c2 into labring:main Nov 18, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants