Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete useless code #4340

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Delete useless code #4340

merged 2 commits into from
Nov 23, 2023

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Nov 23, 2023

πŸ€–[deprecated] Generated by Copilot at be1e665

Summary

πŸ—‘οΈπŸ”§πŸš«

This pull request removes the resources-metering controller and its related code from the controllers and database packages. The controller was deprecated and no longer needed. The pull request also refactors some of the remaining code in those packages to simplify and improve the test and build workflows.

resources-metering
Deprecated, removed from code
Spring cleaning for database

Walkthrough

@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 1036
βœ… Successful 367
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 668
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 23, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (520c69d) 65.45% compared to head (be1e665) 65.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4340   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@bxy4543 bxy4543 merged commit 4efa9d8 into labring:main Nov 23, 2023
76 checks passed
@bxy4543 bxy4543 deleted the delete_useless_code branch November 23, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants