Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): laf template #4351

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

xudaotutou
Copy link
Contributor

@xudaotutou xudaotutou commented Nov 27, 2023

🤖[deprecated] Generated by Copilot at 3309222

Summary

🗑️🐛🚀

This pull request adds new features and fixes a bug for the template provider frontend. It enables the frontend to delete different kinds of resources, such as persistent volume claims, custom resources, and role bindings, by using new API handlers and functions. It also updates the dependencies, adds the pluralize library, and passes the apiVersion of the resources to the delete functions. Additionally, it fixes a bug where the role binding was not deleted in the correct namespace.

Sing, O Muse, of the valiant code review
That brought new functions to the template provider
To delete various resources with skill and care
And fix the bugs that lurked in the role binder

Walkthrough

  • Implement new API handlers and functions for deleting various resources by name, apiVersion, and kind (link, link, link, link, link)
  • Add pluralize dependency and its types to convert resource kinds to plural forms (link, link, link, link, link, link)
  • Add apiVersion property to resource types and adapt functions (link, link, link, link)
  • Create new API client for apiextensions API group (link)
  • Fetch prometheus, prometheus rule, prometheus PVC, service monitor, and probe resources by label selector in listOtherByName API handler (link, link)
  • Check if resource kind has a predefined delete function or use delCR function in listOtherByName API handler (link)
  • Update immer dependency for zustand package (link)
  • Update @babel/core dependency for styled-jsx package (link, link)
  • Remove @babel/core dependency from next package (link)
  • Add next package resolution to pnpm-lock.yaml file (link)
  • Move closing brackets to new lines in index.tsx file of frontend/providers/template/src/pages/deploy folder for code readability and consistency (link, link, link, link, link, link, link)
  • Remove empty line from listOtherByName.ts file of frontend/providers/template/src/pages/api/app folder for code style (link)

@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1036
✅ Successful 363
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 668
❓ Unknown 0
🚫 Errors 4

Errors per input

Errors in README.md

Errors in README_zh.md

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Nov 27, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a8fffa) 65.45% compared to head (3309222) 65.45%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4351   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c121914yu c121914yu merged commit 19340f5 into labring:main Nov 27, 2023
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants