Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update db docs #4381

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Update db docs #4381

merged 6 commits into from
Dec 7, 2023

Conversation

wallyxjh
Copy link
Contributor

@wallyxjh wallyxjh commented Dec 6, 2023

🤖[deprecated] Generated by Copilot at 02a7713

Summary

📝📊🌐

This pull request enhances the documentation and the monitoring of the Database component, especially for the Kafka database. It improves the Chinese translation of the Database component documentation, adds more supported databases and features to the English version, and updates the Prometheus query expressions for Kafka in service/database/api/req.go to match different pod name patterns.

Database of doom, unleash your power
Prometheus queries, devour the Kafka tower
No more experiments, only features and support
English and Chinese docs, spread the knowledge across the globe

Walkthrough

  • Update the introduction of the Database component in both English and Chinese documentation, adding more supported databases and features, and removing the experimental phase statement. (link, link)
  • Update the quick start section of the Database component in the Chinese documentation, adding more screenshots and steps to show how to deploy and access a database cluster. (link)
  • Update the Prometheus query expressions for the Kafka database in the api package, adding more possible pod name patterns to match different Kafka deployments. (link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Dec 6, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1150
✅ Successful 395
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 754
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Dec 6, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Dec 6, 2023

📘 Preview documentation website

👀 Visit Preview

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2255850) 65.45% compared to head (02a7713) 65.45%.
Report is 1 commits behind head on main.

❗ Current head 02a7713 differs from pull request most recent head 9eda369. Consider uploading reports for the commit 9eda369 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4381   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzjin zzjin added this to the v5.0 milestone Dec 7, 2023
@zzjin zzjin merged commit 3963a1a into labring:main Dec 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants