Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acme service type. #4403

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Fix acme service type. #4403

merged 4 commits into from
Dec 12, 2023

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented Dec 12, 2023

πŸ€–[deprecated] Generated by Copilot at 439668d

Summary

πŸ”’βœ¨πŸ”§

Added serviceType property to ingress object in deployYaml2Json.ts to support cert-manager. This allows specifying how the ingress controller is exposed to the cluster network.

serviceType added
to expose ingress better
autumn cert renewal

Walkthrough

  • Add serviceType property to ingress object in http01 object (link) to specify the type of service that exposes the ingress controller to the cluster network. This allows cert-manager to use HTTP-01 challenge to verify domain ownership and issue certificates for the ingress resources.

Signed-off-by: zzjin <tczzjin@gmail.com>
Signed-off-by: zzjin <tczzjin@gmail.com>
Signed-off-by: zzjin <tczzjin@gmail.com>
Signed-off-by: zzjin <tczzjin@gmail.com>
@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 1148
βœ… Successful 388
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 759
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Dec 12, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (9b2fc94) 65.45% compared to head (439668d) 65.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4403   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@bxy4543 bxy4543 added this to the v5.0 milestone Dec 12, 2023
@bxy4543 bxy4543 merged commit c9527a7 into labring:main Dec 12, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants