fix control-plane component status #4749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated by lychee actionSummary
Full action output |
cuisongliu
reviewed
May 29, 2024
| @@ -96,6 +99,13 @@ func (n *ClusterChecker) Check(cluster *v2.Cluster, phase string) error { | |||
| return n.Output(NodeList) | |||
| } | |||
|
|
|||
| func isControlPlaneNode(node corev1.Node) bool { | |||
| if _, ok := node.Labels["node-role.kubernetes.io/control-plane"]; ok { | |||
There was a problem hiding this comment.
Issues with older versions need to be considered
There was a problem hiding this comment.
Agreed,I'll add an old version label to check.
cuisongliu
approved these changes
May 29, 2024
wallyxjh
pushed a commit
to wallyxjh/sealos
that referenced
this pull request
Jul 1, 2024
* fix control-plane component status * add the old version "master" labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix control-plane component status checker.