Database exceptions monitor #4830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
🤖 Generated by lychee actionSummary
Full action output |
bxy4543
force-pushed
the
database-exceptions-monitor
branch
from
f649f30 to
30ab8ea
Compare
bxy4543
reviewed
Jul 4, 2024
| }, ClusterRegionMap, &missingEnvVars) | ||
|
|
||
| if len(missingEnvVars) > 0 { | ||
| return errors.New("missing environment variables") |
service/exceptionmonitor/dao/init.go
Outdated
|
|
||
| func InitCockroachDB() error { | ||
| var err error | ||
| os.Setenv("LOCAL_REGION", "6a216614-e658-4482-a244-e4311390715f") |
There was a problem hiding this comment.
Via environment variables instead of manually setting
bxy4543
reviewed
Jul 4, 2024
| ) | ||
|
|
||
| func InitClient() error { | ||
| kubeconfigPath := "/home/nonroot/kubeconfig/kubeconfig" |
There was a problem hiding this comment.
What is this? Get kubernetes.client through k8s.io/client-go/rest.InClusterConfig()
wallyxjh
force-pushed
the
database-exceptions-monitor
branch
3 times, most recently
from
42583a5 to
dea8d22
Compare
wallyxjh
force-pushed
the
database-exceptions-monitor
branch
from
dea8d22 to
8453f9a
Compare
bxy4543
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.