Add zap4echo to README #2324
Open
Add zap4echo to README #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, but how does your package differ from the existing github.com/brpaz/echozap just the line below yours? |
|
echo4zap is highly configurable whereas echozap is not. In addition to that echo4zap has a logger for panic recovery, which is also configurable. |
|
For adding zap4echo I think having both for now seems ok, as zap4echo is more configurable. @aldas I'd prefer to move the whole third party middlewares seciotn from the README to the echo-contrib project and just add a link in the main repo README to the echo-contrib project. What do you think about that? |
|
There was a merge conflict. I solved it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a middleware package to log requests and to recover from panics. It uses zap, my favorite logging package.