Return an empty string for ctx.path if there is no registered path #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brietaylor
force-pushed
the
brie/consistent-ctx-path
branch
from
4c4b493
to
4105b7b
Compare
|
This will be probably released in next minor version with newer "context" timeout middleware |
danimo
added a commit
to b3scale/b3scale
that referenced
this pull request
Nov 14, 2023
In labstack/echo#2385, a fix for labstack/echo#2384 was added. The proposed fix is to use the path from the Request URL.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #2384