Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization: struct alignment #2636

Merged
merged 1 commit into from
May 30, 2024

Conversation

behnambm
Copy link
Contributor

@behnambm behnambm commented May 29, 2024

Pull requset to resolve #2632

Modified files with saved memory size:

File name Saved size(bytes)
binder.go 40
echo.go 8
echo_fs.go 8
group.go 16
ip.go 8
response.go 16
router.go 32
context.go 16
echo.go 8

Total saved size: 144

There was potential to further optimize the Echo struct in the echo.go file, but I chose to respect the readability of the codebase.

@aldas a quick review from you would be awesome whenever you’re free. Thanks!

Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas aldas merged commit f7d9f51 into labstack:master May 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: Micro-optimization for better memory utilization
2 participants