Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transform.affine_transform() #113

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Add transform.affine_transform() #113

merged 2 commits into from
Nov 19, 2019

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Nov 19, 2019

  • Stop using vg.matrix
  • Inline pad and unpad which aren’t really useful outside this context
  • Make convert_33_to_44() private for the moment

Ref #107

- Stop using `vg.matrix`
- Inline `pad` and `unpad` which aren’t really useful outside this context

Ref #107
@paulmelnikow paulmelnikow changed the title Add transform.affine_transform Add transform.affine_transform() Nov 19, 2019
@paulmelnikow paulmelnikow merged commit 3238283 into master Nov 19, 2019
@paulmelnikow paulmelnikow deleted the matrix-cleanup branch November 19, 2019 19:26
paulmelnikow added a commit to lace/vg that referenced this pull request Jul 10, 2021
Closes #95

Deprecate `vg.matrix.pad_with_ones()`, `vg.matrix.unpad()`, and `vg.matrix.transform()` in favor of `polliwog.transform.apply_transform()`. (See lace/polliwog#113 for additional context on why `pad_with_ones()` and `unpad()` are being removed.)
hopeman1102 added a commit to hopeman1102/vector_geo_toolkit that referenced this pull request May 18, 2023
Closes #95

Deprecate `vg.matrix.pad_with_ones()`, `vg.matrix.unpad()`, and `vg.matrix.transform()` in favor of `polliwog.transform.apply_transform()`. (See lace/polliwog#113 for additional context on why `pad_with_ones()` and `unpad()` are being removed.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant