Plane.line_xsections: Clarify the desired behavior in a degenerate case #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
commented
Sep 30, 2019
| expected = np.array([[np.nan, np.nan, np.nan]]) | ||
| intersections, is_intersecting = plane.line_xsections(pts, rays) | ||
| np.testing.assert_array_equal(intersections, expected) | ||
| np.testing.assert_array_equal(is_intersecting, [False]) |
There was a problem hiding this comment.
I'm not sure it's really worth adding this test, as it basically duplicates behavior from the previous test. If the decision is that this behavior is kept, I can add some comments to the method and the previous test, instead.
paulmelnikow
changed the title
|
Hey @algrs, is this something you'd be able to weigh in on? |
|
Decision:
This will be a breaking change for some users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geometrically, the intersection between a plane and a coplanar line is the line itself.
Plane.line_xsectionsreturns "not intersecting."Is this desirable?
If so, would it make sense to add a second method like
Plane.contains_line()that makes it really easy to check this case?