feat(command): Enable the datacollector service when disabled #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(command): Improve Kubernetes nodes detection When pre-installing the Lacwork agent on an image, the Lacework support team suggests we disable the datacollector service. Therefore, this script needs to enable it. Signed-off-by: Jean-Philippe Lachance <jplachance@coveo.com>
afiune
reviewed
Mar 2, 2021
| # Make sure the Lacework datacollector service is enabled and running | ||
| if ! systemctl is-active --quiet datacollector; then | ||
| echo "Enabling the Lacework datacollector service" | ||
| systemctl enable datacollector |
There was a problem hiding this comment.
what if the service is enabled but not active? would this fail? 🤔
There was a problem hiding this comment.
I just did the test, I confirm I confirm enabling an already enabled service does not cause any issue.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(command): Enable the datacollector service when disabled
fix(command): Improve Kubernetes nodes detection
When pre-installing the Lacework agent on an image, the Lacework support team suggests we disable the datacollector service. Therefore, this script needs to enable it.
Signed-off-by: Jean-Philippe Lachance jplachance@coveo.com