fix: empty project_id in google_project data source #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A validation change hashicorp/terraform-provider-google#12846 was introduced in version
4.42.0
of the google provider. This validation makes all our GCP modules to fail with:To solve this issue we are avoiding using the
google_project
data source when we know theproject_id
that was provided by the user.If the user does not provide a
project_id
, then we use the data source to discover the project from the google provider.Signed-off-by: Salim Afiune Maya afiune@lacework.net
How did you test this change?
Test should pass, plus we will test this in our private Terraform project https://github.com/lacework/terraform-customerdemo
Issue