Build multi-arch k8s-helm image #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use multi-arch build github action for helm image. Also use docker buildx env variable to properly identify target arch in the Dockerfile https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
|
This is excellent. Thanks for the contribution. Will review (sorry for the delay) |
|
I've merged this in. Please try out the latest OR v3.6.0 image to test the multi-arch images. Do you need this patch backported to a branch? |
|
yep, the latest version runs on
No, latest is enough, thank you. |
|
Excellent. Thank you so much for your contribution and my apologies for taking so long to action. |
This was referenced Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use multi-arch build github actions for helm image, see https://github.com/docker/build-push-action#multi-platform-image
to get multi-arch image for
linux/amd64,linux/arm64,linux/s390x,linux/ppc64learchitecturesdocker/build-push-action@v1todocker/build-push-action@v2to build multi-arch imagescrazy-max/ghaction-docker-meta@v1action to get labels and tags, see https://github.com/docker/build-push-action#handle-tags-and-labelsAlso use docker buildx env variable(
TARGETARCH) to properly identify target arch inthe Dockerfile https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope
amd64 is still default one and pure
docker buildwill be done without any extra steps.See Github action logs for master branch of fork repo here.