Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default task pools and method for configuring them #2

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

aclysma
Copy link
Collaborator

@aclysma aclysma commented Aug 25, 2020

Remove generics from TaskPool newtypes and some of the task API
Add IO, AsyncCompute and Compute TaskPools
Move TaskPool setup from bevy_ecs to bevy_app
ParallelExecutorOptions is essentially replaced by DefaultTaskPoolOptions

Add IO, AsyncCompute and Compute TaskPools
Move TaskPool setup from bevy_ecs to bevy_app
ParallelExecutorOptions is essentially replaced by DefaultTaskPoolOptions
…ate module

Add a prelude to bevy_tasks
Update the version of bevy_tasks to match other crates
Copy link
Owner

@lachlansneff lachlansneff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks great. I left a few comments asking about decisions here or there, but otherwise, this is absolutely ready to merge.

crates/bevy_app/src/task_pool_options.rs Show resolved Hide resolved
crates/bevy_app/src/task_pool_options.rs Show resolved Hide resolved
crates/bevy_ecs/src/resource/resources.rs Show resolved Hide resolved
crates/bevy_tasks/src/usages.rs Show resolved Hide resolved
@lachlansneff
Copy link
Owner

This looks great!

@lachlansneff lachlansneff merged commit e406b07 into lachlansneff:bevy-tasks Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants