-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/omf-release-0.1 #202
docs/omf-release-0.1 #202
Conversation
* Add MDS-Web-Sockets docs * Typo * Remove example response
twiddle README add NOT FOR CONTRIB to service-areas
Looks great so far. One likely change to discuss. Jascha would like to make the repo root readme files read mostly the same. If we can all agree to that, then the current mds-core readme.md will need to change to something like DevWorkstationSetup.md. I will push an update on this PR today for review. |
replace paragraphs 2,3 as too spec related with a link to spec readme instead move mds-core development guidelines to CONTRIBUTING.md add a missing link change the order of the table items make a command decision on using mds-core instead of MDS-core
also eliminate garbage from bad markdown linter
Starting to review dev workstation setup (after moving it from the root readme) which is now part of this PR. I went back through the openstack infrastructure management and project creation guides as reference for running local and remote tests. |
- readme changes similar to lacuna-tech/mds-core#202 - move configuration from readme to CONFIGURATION.md - changes in preperation for first OMF release
…in some cases, mark packages not intended for contrib.
missing one ref and it didnt read well
# Conflicts: # README.md # packages/mds-event-processor/README.md # packages/mds-geography/README.md
also a bit about experimental content
some basic reorganization so it is easier to follow steps added index ill start verifying steps next after that a pass at vm in win, vm in macos
Using a few other projects as a guide
plus a few fix ups
# Conflicts:
- shell commands and multi line outputs are bracketed as code - single line outputs are bracketed as inline code - Moved a few sections to operations - Added package descriptions - Added expected install results Some errors were logged as part of the mds-core bootstrap script. I will post these to the PR. I got all the way to the mds-core build section, where I get `curl: (52) Empty reply from server` after running 'curl localhost/agency’.
While working on DevWorkstationSetup.md, I have been following the steps. This is what I have found so far
|
I needed to manually reset the node version for yarn. Once past that the install part of the script appears to exit clean. However, during the build it existed with @container-images/mds-geography-author: ../../node_modules/@mds-core/mds-types/dist/index.d.ts(2,72): error TS2306: File '/Users/sarob/code/lacuna-tech-mds-core/node_modules/@mds-core/mds-types/dist/scopes.d.ts' is not a module. I will include the updated config files this time.
I figured out the bootstrap script install. Small tweak now part of the doc. Now working through a bootstrap script build problem. |
|
||
# Authentication & Identity | ||
We authenticate and authorize access to APIs and public-facing websites using JSON Web Tokens (JWT). JWTs are issued by Auth0 using the OAuth 2.0 protocol. | ||
## Auth0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a sentence or two about why we chose Auth0 and the pros of cons of other authentication alternatives might be nice too (since my understanding is that while implementers need to use JWTs, they might not choose to use Auth0 to handle JWTs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree that adding some additional information about Auth0 would be great
The repo currently has integration tests with code-coverage minimums on a per-project basis. [TODO add more] | ||
# Versioning | ||
The services in mds-core will follow the MDS spec’s requirements for [API versioning](https://github.com/openmobilityfoundation/mobility-data-specification/blob/dev/general-information.md). | ||
# Shared Libraries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be updated to add mds-service-helpers
and mds-webpack-config
## mds-utils | ||
Grab-bag of shared utility methods. Including, but not limited to: Programmatic representation of the MDS-Agency State Machine, date-time converters, and geospatial analysis methods. | ||
## mds-web-sockets | ||
Implementation of a basic websocket model for MDS. Enables real-time external consumption of data through a pub/sub model. See package documentation for specific examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention that it's probably a better practice to use NATS instead of hooking into the web sockets directly?
@Karcass Is this PR stale and can be closed? |
Closing due to inactivity |
Separate PR for documentation, so that you don't have to dig around in the catch-up PR.
This PR should be merged before the catch-up PR so that it's included.
Edits and requests for additional documentation are welcome and encouraged.