Initial mds.metrics stream processor #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consume messages from mds.metrics Write to database using metrics service
avatarneil
approved these changes
Apr 28, 2020
| write: async message => { | ||
| try { | ||
| // TODO: Switch to MetricsServiceClient | ||
| await MetricsServiceProvider.writeMetrics(asArray(message)) |
There was a problem hiding this comment.
We also likely want to do some object validation prior to shipping the metric off to the metrics service
mdurling
pushed a commit
that referenced
this pull request
Apr 28, 2020
* Use entry points from packages folder for images * Update scripts to start processors * Initial mds.metrics stream processor (#286) * Initial mds.metrics stream processor Consume messages from mds.metrics Write to database using metrics service
evanxadkins
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consume messages from mds.metrics
Write to database using metrics service