Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mds-utils] Move generic passing in isDefined so T can be properly inferred #306

Merged
merged 4 commits into from
May 7, 2020
Merged

[mds-utils] Move generic passing in isDefined so T can be properly inferred #306

merged 4 commits into from
May 7, 2020

Conversation

avatarneil
Copy link

PR Checklist

  • simple searchable title - [mds-db] Add PG env var, [config] Fix eslint config
  • briefly describe the changes in this PR
  • mark as draft if should not be merged
  • write tests for all new functionality

Impacts

  • Provider
  • Agency
  • Audit
  • Policy
  • Compliance
  • Daily
  • Native
  • Policy Author

@avatarneil avatarneil self-assigned this May 6, 2020
mdurling
mdurling approved these changes May 6, 2020
View reviewed changes
Copy link

@mdurling mdurling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on previous PR that arrived late.

packages/mds-jurisdiction-service/service/repository/index.ts Outdated Show resolved Hide resolved
@avatarneil avatarneil merged commit 17814e7 into develop May 7, 2020
@avatarneil avatarneil deleted the feature/neil/more-filter-empty-reworking branch May 7, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macsj200 macsj200 macsj200 approved these changes

@mdurling mdurling mdurling approved these changes

@janedotx janedotx janedotx approved these changes

Assignees

@avatarneil avatarneil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avatarneil @janedotx @mdurling @macsj200