Fix PR Template #333
Merged
Fix PR Template #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdurling
requested review from
janedotx,
twelch,
BigIdeas,
marie-x,
avatarneil,
wesleyfsmith,
macsj200,
evanxadkins and
levi217
BigIdeas
approved these changes
May 18, 2020
avatarneil
approved these changes
May 18, 2020
|
Silly man, you think most people use the PR templates |
macsj200
approved these changes
May 19, 2020
added 2 commits
May 19, 2020 09:38
avatarneil
reviewed
May 19, 2020
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| - [ ] Native | ||
| - [ ] Policy Author | ||
| ## Resolves: | ||
| - [ ] gitmoji + ticket `🐛 JRA-834 fixes bug in the tubes` |
There was a problem hiding this comment.
In a public repo I feel like this doesn't make a ton of sense
There was a problem hiding this comment.
It could be a reference to a Github issue that is resolved, no?
added 3 commits
May 19, 2020 09:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Impactslist in the PR template is out of date.