Use res.getHeaders() to avoid deprecation warning

[ad-m]

See #1502

[thw0rted]

This isn't the only place where _headers is referenced, just look down a few lines in the file you changed. See my comments on the linked issue for more details. ETA: I misunderstood how the local headers var was being used, so it should be enough to just replace subsequent references to req._headers with the local headers.

[thw0rted]

Also: on L509 and L522, I think the headers = is extraneous. The method returns a reference to its first parameter, which is going to have to be headers anyway, so the assignment will do nothing.

[niftylettuce]

Do we need tests added?

[ad-m]

Rebased to build on Node 12. Added --throw-deprecation to fail (see https://devdocs.io/mocha/ detail), when deprecated method used.

[ad-m]

Is there anything what I can do to help merge that PR?

[busticated]

hi all 👋

thanks for all the work in pulling this together and maintaining this lib over the years 🙏🙇

fwiw, this is blocking formal node@12 support over in https://github.com/particle-iot/particle-cli (see failing tests here).

i'd be happy to pitch in w/ additional fixes and / or testing as you see fit 👍

[niftylettuce]

v5.1.2 is released to npm and everything should be fine with latest versions of Node now 🎉

If you find any further deprecation warnings in the future please let me know!

npm install superagent@latest

or with yarn:

yarn add superagent@latest

https://github.com/visionmedia/superagent/releases/tag/v5.1.2