fix: ensure node retries happen when using .then syntax (#1487) #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @niftylettuce! We're quite keen to see this fixed as we're having a number of socket timeout errors. I'm wondering when you'll have an opportunity to review this PR. Is there something I can do to make it happen? Thank you |
|
v5.3.0 published to npm and GitHub releases page with changelog |
|
@niftylettuce thank you for releasing this! |
|
no prob |
|
|
|
Oh sorry, I commented on the wrong issue. Ignore this. |
|
For reference, or if you want to help debug, see #1527. |
This was referenced Jul 16, 2024
This was referenced Jul 24, 2024
This was referenced Aug 2, 2024
This was referenced Sep 6, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to enforce consistent
retrybehaviour for both the.endand.thensyntaxes.The problem I'm trying to fix has been highlighted in these issues:
When using
.thensyntax in Node.js, we only want to abort a request if there are no retries or the maximum number of retries has been exceeded.Please review