Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Support port overrides in connect() #1564

Merged
merged 2 commits into from
Jun 28, 2020

Conversation

bennbollay
Copy link
Contributor

Allow for .connect({'*': {host: 'hostname', port: 12345}}) overrides to
change the destination port of a request.

Allow for .connect({'*': {host: 'hostname', port: 12345}}) overrides to
change the destination port of a request.
@bennbollay bennbollay changed the title Support port overrides in connect() feature: Support port overrides in connect() May 27, 2020
@@ -1,7 +1,7 @@
{
"name": "superagent",
"description": "elegant & feature rich browser / node HTTP with a fluent API",
"version": "5.2.2",
"version": "5.2.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not version bump package.json. If you remove this commit I will merge it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @niftylettuce !

@niftylettuce niftylettuce merged commit 7a25f3e into ladjs:master Jun 28, 2020
@niftylettuce
Copy link
Collaborator

Ill do this myself nvm

@niftylettuce
Copy link
Collaborator

v5.3.0 published to npm and GitHub releases page with changelog

niftylettuce added a commit that referenced this pull request Jun 28, 2020
@bennbollay bennbollay deleted the connect-with-port-override branch June 29, 2020 18:35
This was referenced Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants