Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send cookies to allowed domains #1757

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Send cookies to allowed domains #1757

merged 1 commit into from
Jan 18, 2023

Conversation

ShiraNagen
Copy link
Contributor

@ShiraNagen ShiraNagen commented Dec 15, 2022

Currently, superagent.agent() sends cookies to all requests without checking if the domains match the cookies and are allowed to use them.
This pull request solves this issue #1758.

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@titanism titanism merged commit 93835cb into ladjs:master Jan 18, 2023
@titanism
Copy link
Collaborator

@titanism
Copy link
Collaborator

thank you for your contributions @ShiraNagen 👏 🎉

@ShiraNagen ShiraNagen deleted the cookies-domains branch January 22, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants