fix: unify body and query serialisation behaviour #1808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
#1591 changed things to use
qs
to serialise form data. However, that change setqs.stringify
as the body serialisation function i.e. default options. The existing query serialisation usesqs.stringify
withindices: false
andstrictNullHandling: true
options (src/node/index.js
line 679).Existing documentation indicates that body serialisation with duplicated object keys should result in the same behaviour as the existing query serialisation. However,
qs.stringify
with default options results in a different outcome, as described in the issue this PR closes.This PR
Linked issue
Closes #1798
Checklist