fix(validation): Tweak ValidationError to work for multiple objects #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswmackey
added a commit
to chriswmackey/honeybee-core
that referenced
this pull request
Jul 25, 2023
This change is meant to align with this PR here: ladybug-tools/honeybee-schema#375 The new capability of reporting multiple invalid objects in a single error is being used in two places: - In a new and improved check for overlapping sub-faces, where all of the overlapping sub-faces are reported - In the check for adjacent objects with mis-matched areas. In this case, both of the adjacent objects are reported so that the msi-match is clear to see. This commit it also removing all of the check_non_zero methods, which have never been used in validation and, for the places where this type of check matters, there are much better versions of this check.
|
🎉 This PR is included in version 1.53.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @MingboPeng