Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kwarg for newer versions of prometheus client #102

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Remove kwarg for newer versions of prometheus client #102

merged 1 commit into from
Jun 22, 2020

Conversation

tyler-8
Copy link
Collaborator

@tyler-8 tyler-8 commented Jun 21, 2020

Fixes #101

lae
lae approved these changes Jun 22, 2020
View reviewed changes
Copy link
Owner

@lae lae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this against master? I'm not sure how I missed pushing the django-rq fix to master last month.

@tyler-8
Copy link
Collaborator Author

tyler-8 commented Jun 22, 2020

Rebased, will merge once CI completes.

@lae
Copy link
Owner

lae commented Jun 22, 2020

Passed: https://travis-ci.org/github/lae/ansible-role-netbox/builds/700945098 (GH not reflecting it)

@lae lae merged commit 09df22a into lae:master Jun 22, 2020
@tyler-8 tyler-8 deleted the metrics_cfg_fix branch May 17, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lae lae lae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update configuration.py template for prometheus_client change
2 participants
@tyler-8 @lae