Allow upgrade step to be configurable #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dist upgrade only when enabled
set default `true` for pve_dist_upgrade
lae
reviewed
Mar 19, 2018
tasks/main.yml
Outdated
| @@ -66,6 +66,7 @@ | |||
| update_cache: yes | |||
| cache_valid_time: 3600 | |||
| upgrade: dist | |||
| when: pve_dist_upgrade | default(true) | |||
There was a problem hiding this comment.
The default filter here is redundant since it's already specified as a default in defaults/main.yml. Can you remove this?
Actually, I think it would be a better option to move the variable to the upgrade parameter and allow users to configure either a safe-upgrade or dist-upgrade, because with this method we're skipping all upgrades.
There was a problem hiding this comment.
you're right, with upgrade we have better options to perform upgrade.
|
Can you also add this variable to the documentation as well? |
updated README.md
lae
reviewed
Mar 19, 2018
tasks/main.yml
Outdated
| @@ -65,7 +65,7 @@ | |||
| apt: | |||
| update_cache: yes | |||
| cache_valid_time: 3600 | |||
| upgrade: dist | |||
| upgrade: pve_upgrade | |||
There was a problem hiding this comment.
pve_upgrade needs to be "{{ pve_upgrade }}" so that the variable gets interpreted properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes dist upgrade operation can be dangerous.
so would nice to set otherwise.
ps: it's enabled by default