Corosync role variable handling #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace ring0_addr/ and friends with addr0/addr1 Remove bindnet vars and flags Deduplicate some tasks Check for facts instead of IPv4 address for cluster hosts
|
Backwards compat test: https://travis-ci.org/lae/ansible-role-proxmox/jobs/596410730 |
|
@trickert76 if you've got time to look at this, let me know. Otherwise I'm just gonna merge near the end of the week. |
|
I'll try to check that today. |
yaml is such a pain sometimes
lae
force-pushed
the
feature/ring0_references
branch
from
9bbec82
to
397aa9f
Compare
|
Looks good to me. |
trickert76
reviewed
Oct 12, 2019
| # PVE 6.x (Debian Buster) clustering options | ||
| pve_cluster_link0_addr: "{{ ansible_default_ipv4.address }}" | ||
| # pve_cluster_link1_addr: "another interface's IP address or hostname" | ||
| # pve_cluster_addr0: "{{ ansible_default_ipv4.address }}" |
There was a problem hiding this comment.
Just my two cents, I've learned, that the default interfaces may change. For example docker installations add docker0 and then because d is before e, the default interfaces in ansible changes. Maybe we should mention that. I've added somewhere else in my playbook a set_fact based on a filter of all interfaces starting with 'e' to get the first address. But when you use more then one ethernet device, this will maybe overridden. Nothing to change here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collapses all of the address-related variables used for bringing up clusters to
pve_cluster_addr0andpve_cluster_addr1, while maintaining backwards compatibility. The bindnet parameters are no longer passed topvecmeither, as they turned out to be redundant to the ring parameters.This also removes instances in the configuration where the hosts' default IPv4 address was used even if ring0 address was overridden. See #47 for more information.