Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for adding authentication realms to domains.cfg #95

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

jfpanisset
Copy link
Contributor

This branch somewhat addresses issue #23 with support for adding non-default authentication domains / realms to /etc/pve/domains.cfg in a similar fashion to the way /etc/pve/datacenter.cfg is handled. This code overwrites the configuration file directly, it would be preferable if a true Python module were written to use the domains REST API but for now this appears to be sufficient to add Active Directory authentication to login to the web UI.

Signed-off-by: Jean-Francois Panisset panisset@gmail.com

Copy link
Owner

@lae lae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this against develop and add an appropriate role variable underneath tests/group_vars/all, as well as some tasks to validate that domains were configured correctly via the API under tests/test.yml

Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
@jfpanisset
Copy link
Contributor Author

Rebased against develop, looking at other requests.

@lae
Copy link
Owner

lae commented May 25, 2020

Thanks for rebasing. It looks like the changeset is incomplete (other than my requests above). pve_domains_cfg needs to be given as a default in defaults/main.yml, otherwise it breaks deployment on the Check domains.cfg exists task:

https://travis-ci.org/github/lae/ansible-role-proxmox/jobs/690697670#L2120

@lae lae merged commit 83941db into lae:develop Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants