Introduce various improvements #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Apple M1 Pro with Apple clang version 16.0.0 compiler:
[ 91%] Building CXX object modules/ar/CMakeFiles/visp_ar.dir/src/panda3d-simulator/vpPanda3DGeometryRenderer.cpp.o
.../modules/ar/src/panda3d-simulator/vpPanda3DGeometryRenderer.cpp:184:33: warning: loop not vectorized: the optimizer was unable to perform the requested transformation; the transformation might be disabled or specified as part of an unsupported transformation ordering [-Wpass-failed=transform-warning]
184 | void vpPanda3DGeometryRenderer::getRender(vpImage<vpRGBf> &normals, vpImage<float> &depth, const vpRect &bb, unsigned int h, unsigned w) const
| ^
1 warning generated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1498 +/- ##
==========================================
+ Coverage 53.88% 53.90% +0.01%
==========================================
Files 442 442
Lines 53778 53793 +15
==========================================
+ Hits 28978 28996 +18
+ Misses 24800 24797 -3 ☔ View full report in Codecov by Sentry. |
SamFlt
reviewed
Nov 4, 2024
| #endif | ||
| for (int j = 0; j < image_width; ++j) { | ||
| int left_j = left + j; | ||
| int j_4 = j + 4; |
There was a problem hiding this comment.
i think this should be int j_4 = j * 4;
There was a problem hiding this comment.
Yes for sure. Thanks. Fixed in next commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.