Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality by fixing issues reported by Sonarqube #1510

Merged
merged 5 commits into from
Nov 28, 2024

Conversation

fspindle
Copy link
Contributor

No description provided.

Improve quality by fixing issues reported by sonarqube
Issue reported by CI
vpImage_lut.h:176:43: error: out-of-line definition of 'performLut' does not match any declaration in 'vpImage<Type>'
template <class Type> void vpImage<Type>::performLut(const Type(&)[256], unsigned int)
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 47.48011% with 198 lines in your changes missing coverage. Please review.

Project coverage is 53.82%. Comparing base (c60ddae) to head (2df7042).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
modules/core/src/image/vpImageConvert.cpp 3.84% 50 Missing ⚠️
modules/core/src/image/vpImageConvert_yuv.cpp 0.00% 18 Missing ⚠️
modules/core/src/tools/geometry/vpRectOriented.cpp 0.00% 16 Missing ⚠️
...re/src/math/transformation/vpHomogeneousMatrix.cpp 50.00% 14 Missing ⚠️
modules/core/src/image/vpCannyEdgeDetection.cpp 0.00% 12 Missing ⚠️
...ore/src/math/transformation/vpForceTwistMatrix.cpp 20.00% 12 Missing ⚠️
...dules/core/src/math/matrix/vpMatrix_operations.cpp 10.00% 9 Missing ⚠️
...ules/core/src/math/transformation/vpRzyxVector.cpp 33.33% 6 Missing ⚠️
...ules/core/src/math/transformation/vpRzyzVector.cpp 33.33% 6 Missing ⚠️
...es/core/src/math/transformation/vpThetaUVector.cpp 66.66% 6 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
- Coverage   53.82%   53.82%   -0.01%     
==========================================
  Files         442      442              
  Lines       53850    53869      +19     
==========================================
+ Hits        28987    28995       +8     
- Misses      24863    24874      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit 275bf9c into lagadic:master Nov 28, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant