Print informative message after "lago ovirt start" #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvgoldin
reviewed
Apr 24, 2017
ovirtlago/cmd.py
Outdated
| 'You can access the web UI with the following link and credentials:\n' | ||
| 'https://{ip}\n' | ||
| 'Username: {username}\n' | ||
| 'Password: {password}'.format( |
There was a problem hiding this comment.
I think using """ would be nicer(and then you don't need the explicit eol'), i.e.:
LOGGER.info("""
oVirt ....
""".format)
|
great idea! |
gbenhaim
force-pushed
the
print_message_lago_ovirt_start
branch
from
0976336 to
b660f5b
Compare
gbenhaim
force-pushed
the
print_message_lago_ovirt_start
branch
from
b660f5b to
9a735ce
Compare
mykaul
approved these changes
Apr 27, 2017
nvgoldin
approved these changes
Apr 27, 2017
The message will include the url to the web ui, username and password. Signed-off-by: gbenhaim <galbh2@gmail.com>
gbenhaim
force-pushed
the
print_message_lago_ovirt_start
branch
from
9a735ce to
9cf732e
Compare
|
ci test please |
1 similar comment
|
ci test please |
|
ci merge please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message will include the url to the web UI, username and password.
Signed-off-by: gbenhaim galbh2@gmail.com