-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy shopping cart on centralpark2 #40
Conversation
oc version && echo "oc CLI installed successfully" | ||
} | ||
|
||
installKustomize() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kubectl 1.14+ have kustomize
out-of-the-box. We played with him. OC until haven't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting.
TBH, I added this code here but it's not used and we'll probably remove it. We've found other ways to manage the YAML files without kustomize. This is a left-over from lagom/lagom-scala-openshift-smoketests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've found other ways to manage the YAML files without kustomize
We too 😄
Now for Lagom 1.5.X we migrated from LBO to HELM charts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, I think oc
3.11
uses kubectl
1.11
:-/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
abcc33b
to
dec518c
Compare
7d454f9
to
b997461
Compare
building the docker image in maven fails on travis:
I've managed to reproduce locally by removing all images from the registries I was logged to:
I think the problem is that |
This will resolve #16, right? |
yes, I've updated the description |
Me not pressing
At this point, the only issue pending solution is the installation of Kafka/Strimzi on CentralPark2. |
then | ||
( | ||
cd $SHOPPING_CART_SOURCES | ||
buildSbt $SHOPPING_CART_SOURCES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildSbt $SHOPPING_CART_SOURCES | |
sbt clean docker:publishLocal |
We can simply inline it here.
then | ||
( | ||
cd $SHOPPING_CART_SOURCES | ||
buildMvn $SHOPPING_CART_SOURCES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildMvn $SHOPPING_CART_SOURCES | |
mvn package docker:build |
} | ||
buildMvn() { | ||
mvn package docker:build | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From line 14 to 19 can be removed if inlined below
if [ "$BUILD_TOOL" == "sbt" ] | ||
then | ||
( | ||
cd $SHOPPING_CART_SOURCES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can cd
outside the if
, but inside a ( )
scope block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the ( )
scoping rules so I trust your changes here. :-)
Fixes #16