Deploy shopping cart on centralpark2 #40

ignasi35 · 2019-05-17T13:46:16Z

Fixes #16

ihostage · 2019-05-17T14:49:48Z

shopping-cart/deploy/scripts/common/installers.sh

+    oc version && echo "oc CLI installed successfully"
+}
+
+installKustomize() {   


Kubectl 1.14+ have kustomize out-of-the-box. We played with him. OC until haven't?

Interesting.
TBH, I added this code here but it's not used and we'll probably remove it. We've found other ways to manage the YAML files without kustomize. This is a left-over from lagom/lagom-scala-openshift-smoketests

We've found other ways to manage the YAML files without kustomize

We too 😄
Now for Lagom 1.5.X we migrated from LBO to HELM charts.

Anyway, I think oc 3.11 uses kubectl 1.11 :-/

I realised over the weekend that kustomize being part of kubectl will require us changing some docs. Thanks for sharing @ihostage ! ❤️

ignasi35 · 2019-05-18T12:12:47Z

building the docker image in maven fails on travis:

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running com.example.shoppingcart.impl.ShoppingCartEntityTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.908 sec
Results :
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ shopping-cart ---
[INFO] Building jar: /home/travis/build/lagom/lagom-samples/shopping-cart/shopping-cart-java/shopping-cart/target/shopping-cart-1.0-SNAPSHOT.jar
[INFO] 
[INFO] --- docker-maven-plugin:0.26.1:build (build-docker-image) @ shopping-cart ---
[ERROR] DOCKER> Unable to pull 'adoptopenjdk/openjdk8:latest' from registry 'docker-registry-default.centralpark2.lightbend.com' : unauthorized: authentication required (Internal Server Error: 500) [unauthorized: authentication required (Internal Server Error: 500)]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]

I've managed to reproduce locally by removing all images from the registries I was logged to:

docker images --format='{{println .ID}}'| xargs docker rmi -f  | wc -l

I think the problem is that fabric8's docker-maven-plugin reads the DOCKER_REGISTRY env var that we use on the scripts. Another cause for the problem could be that centralpark's registry is set to not fetch images it doesn't contain.

TimMoore · 2019-05-20T05:08:01Z

This will resolve #16, right?

ignasi35 · 2019-05-20T12:08:22Z

This will resolve #16, right?

yes, I've updated the description

ignasi35 · 2019-05-20T12:11:30Z

Me not pressing send to publish the #40 (comment) and also me squashing commits left the history on this PR a bit confusing. Here's the current status:

This PR already solves the Unable to pull 'adoptopenjdk/openjdk8:latest' from registry issue. The bug was caused by our scripts declaring the DOCKER_REGISTRY ENV_VAR which causes docker-maven-plugin to behave differently.

At this point, the only issue pending solution is the installation of Kafka/Strimzi on CentralPark2.

octonato · 2019-05-21T12:55:16Z

shopping-cart/deploy/scripts/builds.sh

+    then
+        (
+            cd $SHOPPING_CART_SOURCES
+            buildSbt $SHOPPING_CART_SOURCES


Suggested change

buildSbt $SHOPPING_CART_SOURCES

sbt clean docker:publishLocal

We can simply inline it here.

octonato · 2019-05-21T12:56:04Z

shopping-cart/deploy/scripts/builds.sh

+    then
+        (
+            cd $SHOPPING_CART_SOURCES
+            buildMvn $SHOPPING_CART_SOURCES


Suggested change

buildMvn $SHOPPING_CART_SOURCES

mvn package docker:build

octonato · 2019-05-21T12:56:42Z

shopping-cart/deploy/scripts/builds.sh

+}
+buildMvn() {
+    mvn package docker:build
+}


From line 14 to 19 can be removed if inlined below

octonato · 2019-05-21T12:57:12Z

shopping-cart/deploy/scripts/builds.sh

+    if [ "$BUILD_TOOL" == "sbt" ]
+    then
+        (
+            cd $SHOPPING_CART_SOURCES


we can cd outside the if, but inside a ( ) scope block

I'm not familiar with the ( ) scoping rules so I trust your changes here. :-)

ignasi35 added 5 commits May 15, 2019 20:03

Extract YMLs to common folder

0e34faa

Basic deployment of shopping-cart-scala. No Kafka, no inventory,...

4dbdea3

Refactor: extact several deployment steps to functions

5653ad2

Add testing step

d735da5

Add deploy stage on travis (installing oc included)

483b242

ihostage reviewed May 17, 2019

View reviewed changes

ignasi35 added 3 commits May 17, 2019 17:13

Stop if image can't be pushed

e32eb09

multiple fixes (travis, typos, sleeps)

d2545a6

Use PR number on deployment

c3462b0

ignasi35 force-pushed the deploy-shopping-cart-on-centralpark branch 3 times, most recently from abcc33b to dec518c Compare May 17, 2019 21:16

Support java. Support sbt/mvn

b997461

ignasi35 force-pushed the deploy-shopping-cart-on-centralpark branch from 7d454f9 to b997461 Compare May 18, 2019 12:11

ignasi35 mentioned this pull request May 20, 2019

Update Lagom migration docs wrt kustomize stratus lagom/lagom#1947

Open

octonato reviewed May 21, 2019

View reviewed changes

octonato added 2 commits May 21, 2019 16:46

disable inventory tests

b6c1f24

re-enable travis jobs

04fff33

octonato approved these changes May 21, 2019

View reviewed changes

octonato and others added 2 commits May 21, 2019 16:51

simplified script

dfb199a

Merge branch '1.5.x' into 'deploy-shopping-cart-on-centralpark'

6e7c9a4

octonato merged commit 55def0b into 1.5.x May 21, 2019

mergify bot deleted the deploy-shopping-cart-on-centralpark branch May 21, 2019 20:12

dwijnand pushed a commit to dwijnand/lagom-samples that referenced this pull request Aug 5, 2019

Update Lagom to v1.5.1 (lagom#40)

2bde6d6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deploy shopping cart on centralpark2 #40

Deploy shopping cart on centralpark2 #40

ignasi35 commented May 17, 2019 •

edited

Loading

ihostage May 17, 2019

ignasi35 May 17, 2019

ihostage May 17, 2019

ignasi35 May 17, 2019

ignasi35 May 20, 2019

ignasi35 commented May 18, 2019

TimMoore commented May 20, 2019

ignasi35 commented May 20, 2019

ignasi35 commented May 20, 2019 •

edited

Loading

octonato May 21, 2019

octonato May 21, 2019

octonato May 21, 2019

octonato May 21, 2019

ignasi35 May 21, 2019

	buildSbt $SHOPPING_CART_SOURCES
	sbt clean docker:publishLocal

Deploy shopping cart on centralpark2 #40

Deploy shopping cart on centralpark2 #40

Conversation

ignasi35 commented May 17, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ignasi35 commented May 18, 2019

TimMoore commented May 20, 2019

ignasi35 commented May 20, 2019

ignasi35 commented May 20, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ignasi35 commented May 17, 2019 •

edited

Loading

ignasi35 commented May 20, 2019 •

edited

Loading