pdir: Python 3.13 #79
Conversation
Adds the new attributes that were added in Python 3.13 to the test cases and the attribute lists. Perhaps these should live in different categories? Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
|
It seems to me tests should be scoped on their expected values per Python version as they're failing on expected attributes in the tests that don't exist in the versions used for the test :( |
|
Admittedly, the tests are becoming harder and harder to maintain with each new version. Given the code seldom changes and almost never breaks, I think it makes sense to only run the tests under the current and upcoming version, to minimize the maintenance cost. In this case, it means 3.12 and 3.13. To make the tests pass, I suggest to remove Python 3.8 - 3.11 from |
|
Though, you'll still have to deal with the differences between 3.12 and 3.13, which is unavoidable. Or, you can wait for the official release of 3.13, by then I would be fine to remove 3.12 as well. |
|
I'll think about the test situation a bit, the idea of only running on the latest version was also something I thought about (and didn't quite like) :) |
|
Sure, take your time |
|
I saw 3.13 support got into |
|
I should have informed you earlier but I forgot, sorry about that.
Really appreciate it! |
Adds the new attributes that were added in Python 3.13 to the test cases and the attribute lists.
Perhaps these should live in different categories?
Closes #78.