-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for configuring TLS verification policy #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's a very nice PR!
I made some (picky) suggestions, let me know what do you think.
You can also leave some notes and your name in https://github.com/laixintao/iredis/blob/master/CHANGELOG.md 🔮 |
Replace the `if None` checks with a more concise `or` Co-authored-by: laixintao <laixintaoo@gmail.com>
Thanks for the suggestions! I incorporated them in the PR (and validated them with a local test instance 😉). I also updated |
thanks 🍰 |
Hi @laixintao , looks like in versin 1.12.1, the --verify-ssl parameter is not supported , even though the document claims so. |
Given
It will return:
iredis, version 1.12.1 |
hi @introom confirmed this is a release issue, we merged but don't include it in release of 1.12.1. I have released a new version 1.13.0, can you upgrade iredis and try again? thanks. |
I am on homebrew not pip, so gonna be some delay |
Hi! Thanks for this very nice piece of software. First of all, I would like to compliment you for the high quality python code in this repo. It is refreshing to read it.
I am opening this PR to add support for explicit configuration of the
ssl_cert_reqs
parameter, in case the connection schema isrediss
. I took the liberty to also update theREADME
with an updatediredis --help
.To pass values to the underlying
SSLConnection
object, the user has now two choices:ssl_cert_reqs
as a query parameter in the url specified via--url
--verify-ssl
optionBoth check that the value be among
none
,optional
orrequired
, and the former takes precedence over the latter (same behavior as thedb
parameter).This should tackle issue 403.