Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature or bug? All .dot files are ignored #21

Closed
y653 opened this issue Oct 18, 2024 · 8 comments
Closed

Feature or bug? All .dot files are ignored #21

y653 opened this issue Oct 18, 2024 · 8 comments

Comments

@y653
Copy link

y653 commented Oct 18, 2024

Hello again, and thanks your your great work.

I realised that all files beginning with a dot (.chkbit, .config, etc) are ignore from the checksuming process. I understand that this should be the default for .chkbit files that are produced during the checksumming phase, but what about all other .dot files? I have plenty of them in a linux PC, and I realised that these are not included in the checksums, even though I do not use any .chkbitignore file at all. I think that only .chkbit files should be excluded and all others only when they are included in the .chkbitignore file, possibly with wildcards (eg .conf*).

If you agree, you could probably include this change in a following version.

Again, thanks your your hard work!

@laktak
Copy link
Owner

laktak commented Oct 21, 2024

They are not included by default but I'll add an option so you can include them if you wish.

@y653
Copy link
Author

y653 commented Oct 21, 2024

That would be great, thank you!! All the best!

laktak added a commit that referenced this issue Oct 21, 2024
@laktak
Copy link
Owner

laktak commented Nov 5, 2024

I forgot to comment, that option is now included.

@y653
Copy link
Author

y653 commented Nov 6, 2024

Great thanks!
In the releases though I see still the 5.2.0 version, that does not have this option.

@laktak
Copy link
Owner

laktak commented Nov 6, 2024

Well the idea is that you test this before I do a release.

If you cannot build the source yourself, I've added prerelease-artifacts:

Prereleased versions can be found directly on the Git Action. Click on the latest action and look for prerelease-artifacts at the bottom.

You can download the zip and then extract the binary for your platform.

@y653
Copy link
Author

y653 commented Nov 7, 2024

Thanks, I downloaded it.

@laktak
Copy link
Owner

laktak commented Nov 21, 2024

I assume it works for you.

@laktak laktak closed this as completed Nov 21, 2024
@y653
Copy link
Author

y653 commented Nov 26, 2024

Sorry, I did not have the time to test it. I tested it right now, and it works just fine! Thank you very much for your time!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants