Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlinks to license files #855

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

Pat-Lafon
Copy link
Contributor

Closes #600

I don't fully understand the license implications here but from my reading, the correct solution from cargo has not fully manifested yet. In looking what other projects like tokio/regex do, they include the license files in each project so it seems reasonable to follow that strategy.

See bytecodealliance/wasmtime#4664 tokio-rs/tracing#842 rust-lang/cargo#8537 for some discussion on these issues.

@dburgener
Copy link
Contributor

I read the associated links, and it seems like this is the right thing to do. Ideally, cargo would have support for copying this automatically, but since they've opted against doing that, it seems like this is what we need to do in order to meet our obligations under the apache and MIT licenses.

The biggest problem with duplication in software repos IMO is the risk of missing a copy when changing things. In the case of symlinks, this is only a problem if we move or rename our license files, which I imagine is something that would happen very infrequently.

@youknowone youknowone added this pull request to the merge queue Jan 8, 2024
Merged via the queue into lalrpop:master with commit c5827f5 Jan 8, 2024
9 checks passed
@Pat-Lafon Pat-Lafon deleted the license_dups branch February 8, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please include LICENSE-* files in all published crates
3 participants