Switch to Bazel-built mksquashfs #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having Bazel build
mksquashfsfrom source should help with cross-target appimage building, which has mksquashfs running in exec configuration. With this setup, Bazel should do the right (:tm:) thing automatically. There is no need to pull in multiple mksquashfs static binaries.Note that the mksquashfs we build here only supports gzip and zstd compressors. This is the same set as in the previous mksquashfs from https://github.com/lalten/static-tools/releases/tag/build-2022-10-02-f8b7a56
The zlib (for gzip) is taken directly from Bazel itself, so only zstd is a new external transitive source dependency.