Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request file support #19

Merged
merged 7 commits into from
Apr 19, 2023
Merged

Request file support #19

merged 7 commits into from
Apr 19, 2023

Conversation

jtof-fap
Copy link
Collaborator

@jtof-fap jtof-fap commented Apr 18, 2023

Hey ! back to the pull requests, it's been a long time.

Several improvements on the program core :

  • First commit to display the command as a string instead of a list (with native shlex.join() call) when the curl command is show on stdout;

  • The second commit to add the request file support with -R, --request option, like -r option of sqlmap. In this case, the request protocol can't be guessed from file, so http by default or https if --request-tls option is present. You can now easily BUP an authenticated POST request. Copy/paste your Burp request in a file and let's go !

  • The third commit solves a bug in the resolution of absolute filenames when the program loads payload files. You can now call bypass_url_parser from anywhere, even with a symbolic link. :-)

  • The fourth commit reduces HTTP error warnings to the debug level instead of the verbose level;

  • The fifth commit to parse the HTTP version in request file (missing in second commit);

  • The last commit adds an internal/external notion for absolute path resolution. Ex: payload files => internal, absolute resolution from the project directory (useful to call the tool from anywhere) VS request file => external absolute resolution from the file directory.

:-)

@jtof-fap
Copy link
Collaborator Author

No change on bypass methods or payloads so no difference between bup-payloads-2023-04-18.lst file with previous version:

$ git diff --no-index tests-history/bup-payloads-2022-11-21.lst tests-history/bup-payloads-2023-04-18.lst

@jtof-fap jtof-fap requested a review from laluka April 19, 2023 00:34
Copy link
Owner

@laluka laluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the code, went through the tests, that's flawless work, let's merge it quick! 🌹

@laluka laluka merged commit 6fdb3a7 into main Apr 19, 2023
@laluka laluka deleted the jtof-fap-request-file branch April 19, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants