Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 85km/h YPort mode to Speed #288

Merged
merged 16 commits into from
Oct 29, 2022
Merged

Conversation

Doogie13
Copy link
Contributor

@Doogie13 Doogie13 commented Apr 4, 2022

Describe the pull
Add a simple Boost (aka Ground Strafe, aka Alerithe) mode to Speed, similar to YPort in function but completely silent
85km/h NCP YPort

Describe how this pull is helpful
Allows the player to move faster on ground, bypasses better than the current OnGround

Additional context
Video on a local NCP server, Updated video

@mmvanheusden
Copy link
Contributor

mmvanheusden commented Apr 4, 2022 via email

@Doogie13
Copy link
Contributor Author

Doogie13 commented Apr 5, 2022

Please note this speed mode will not work on Updated-NCP as it relies on changing Y speed rapidly which flags but this will work on normal NCP (non strict servers)

@Avanatiker Avanatiker added the enhancement New feature or request label Apr 6, 2022
@Avanatiker
Copy link
Member

Any big servers where this works?

@Doogie13
Copy link
Contributor Author

Any big servers where this works?

It will work in any situation a good OnGround bypasses (lambda OnGround is not a proper OnGround since it doesn't try to adjust Y at all). For example: 2b2t when under blocks, 2b2tpvp, most servers with normal NCP movement checks (a LOT of clones).

@Doogie13
Copy link
Contributor Author

I will try this on some popular servers when I am home and send a video

@Doogie13
Copy link
Contributor Author

Doogie13 commented Apr 11, 2022

Ok so i cba to make a video but i tested it on these servers:
2b2tpvp -> O
CPvP.cc -> X (Works under blocks)
2b2t.dev -> X (Works under blocks)
5b5t.org -> O
9b9t.org -> O
tree.ac (random NCP test server) -> O

basically it worked in all places using NCP speed checks (cpvp.cc uses very strict custom speed checks, 2b2t.dev uses U-NCP)
and where it works, it works flawlessly, other than a couple hiccups when moving between under and not under blocks on any server (literally 1 rubberband and then it works fine again)

@Avanatiker Avanatiker marked this pull request as draft May 2, 2022 15:40
@Avanatiker
Copy link
Member

Needs merged ongrounds

@Doogie13
Copy link
Contributor Author

Doogie13 commented May 7, 2022

This is incoming. There will be an option to accelerate and an option not to since not accelerating is more consistent for some things but accelerate is faster for travel and flat duels

Doogie13 added 2 commits May 7, 2022 21:25
# Conflicts:
#	src/main/kotlin/com/lambda/client/module/modules/movement/Speed.kt
@Doogie13
Copy link
Contributor Author

Doogie13 commented May 8, 2022

Made it a proper onground/yport now, I will test on different servers shortly
Edit, no need to test on other servers since this works the same as literally every other YPort and I cba

@Doogie13
Copy link
Contributor Author

Doogie13 commented May 8, 2022

Video on local NCP server. This will work anywhere normal OnGround/YPort will.

@Doogie13 Doogie13 changed the title Add Boost mode to Speed Add 85km/h YPort mode to Speed May 10, 2022
Added maximum speed slider
Added Air Strict mode to emulate Y motion better
Inflicted pain on Doogie13
@Doogie13
Copy link
Contributor Author

Unless there is any glaring flaws in this code, I have pulled a Techale and added as many options as one would need for any server ever. You can just use defaults most of the time.

@Doogie13
Copy link
Contributor Author

DO NOT MERGE YET

@Doogie13
Copy link
Contributor Author

Doogie13 commented May 11, 2022

Once this next push is tested, this will be finally ready to merge

@Doogie13
Copy link
Contributor Author

Has anyone tested this? I tested it on NCP but not Updated-NCP, nor 2bs fork.

@Avanatiker
Copy link
Member

I tested it on 2b and i cant find a setting that works :c maybe i did it wrong?

@Doogie13
Copy link
Contributor Author

I tested it on 2b2t and got results similar to strafe, which is good becuase this looks smoother. also this is more meant for normal ncp so having it work on 2b2t with some work is very nice

@Doogie13
Copy link
Contributor Author

image
2b2t.org config 28-29km/h and fairly consistent, though this is more for NCP rather than UpdatedNCP

@czho
Copy link
Member

czho commented Jun 29, 2022

based

@Doogie13
Copy link
Contributor Author

Doogie13 commented Aug 8, 2022

can this not be merged? idk how I can improve it

@mmvanheusden
Copy link
Contributor

Is this still going to be merged? I think it is unacceptable that this has been open for 6 months without being looked at

@Doogie13 Doogie13 marked this pull request as ready for review September 29, 2022 07:10
@NCPUser
Copy link

NCPUser commented Oct 6, 2022

YPort No Speed Mod
What Speed?

@Doogie13
Copy link
Contributor Author

YPort No Speed Mod
What Speed?

Excuse me?

@Avanatiker
Copy link
Member

Avanatiker commented Oct 29, 2022

Finally found a working mode for 2b: Mode: Strafe, Auto Jump: true, AirSpeedBoost: 0.037 and Only strafe on overhead: true gives 42 km/h

@Avanatiker
Copy link
Member

Sorry for this being stuck here for so long!

@Avanatiker Avanatiker merged commit 7d37d75 into lambda-client:master Oct 29, 2022
@Doogie13 Doogie13 deleted the Speed branch January 15, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants