fixes #306 and fixes MobOwner name tags still visible after toggling #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at: prepend the original customNameTag to the stateful one.
Avanatiker
approved these changes
Jun 30, 2022
|
Thanks a lot for contributing and improving our mod! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
This pr fixes #306 and sets the entities' name tags back to their original ones after toggling MobOwner, rather than still having the stateful one.
Describe how this pull is helpful
No more unnecessary HTTP requests to the Mojang API when an entity's OwnerUUID is invalid/unknown. Also greatly improve the responsiveness of the MobOwner module by also displaying the original entity's customNameTag and displaying updates to it.
Additional context
n/a