Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the DiscordRPC delay from seconds to ms #404

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

CozyMeli-gitv2
Copy link
Contributor

Describe the pull
Changed the DiscordRPC delay from seconds to ms

Describe how this pull is helpful
Much better to have it in ms, as seconds are a rather large unit of measurement. And 60 seconds of delay max would have RPC time out. Now, it goes from a minimum of 200 ms, to a max of 2000ms, preventing too much delay that it times out, but ensuring that even though it has the option to minimize delay at 200ms, it does not spam the RPC either.

Additional context
none

@nickcat325
Copy link
Contributor

nickcat325 commented Oct 15, 2022

I think you messed up your conversion. If you want milliseconds you have to remove the multiplier. You could use half seconds. If you coded that in.

@CozyMeli-gitv2
Copy link
Contributor Author

feel free to fix it and make a better pull for this, I don't really know what I'm doing lmfao

@nickcat325
Copy link
Contributor

nickcat325 commented Oct 16, 2022

I can. You would need to give me r+w access (or I would have to make a pull request). Also you would have to tell me how you want it set up.

@nickcat325
Copy link
Contributor

Minimum value, max value, format(seconds or milliseconds), and default value.

@Avanatiker Avanatiker merged commit 0ca4d83 into lambda-client:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants